Merge f7409053cd into b5800f7dfc

v2rayN/ServiceLib/Manager/CertPemManager.cs

@@ -215,7 +215,7 @@ public class CertPemManager
             using var client = new TcpClient();
             await client.ConnectAsync(domain, port > 0 ? port : 443, cts.Token);
 
-            await using var ssl = new SslStream(client.GetStream(), false, ValidateServerCertificate);
+            using var ssl = new SslStream(client.GetStream(), false, ValidateServerCertificate);
 
             var sslOptions = new SslClientAuthenticationOptions
             {
@@ -262,7 +262,7 @@ public class CertPemManager
             using var client = new TcpClient();
             await client.ConnectAsync(domain, port > 0 ? port : 443, cts.Token);
 
-            await using var ssl = new SslStream(client.GetStream(), false, ValidateServerCertificate);
+            using var ssl = new SslStream(client.GetStream(), false, ValidateServerCertificate);
 
             var sslOptions = new SslClientAuthenticationOptions
             {
@@ -280,7 +280,11 @@ public class CertPemManager
             var chain = new X509Chain();
             chain.Build(certChain);
 
-            pemList.AddRange(chain.ChainElements.Select(element => ExportCertToPem(element.Certificate)));
+            foreach (var element in chain.ChainElements)
+            {
+                var pem = ExportCertToPem(element.Certificate);
+                pemList.Add(pem);
+            }
 
             return (pemList, null);
         }

v2rayN/ServiceLib/Services/CoreConfig/Singbox/SingboxConfigTemplateService.cs

@@ -23,7 +23,7 @@ public partial class CoreConfigSingboxService
         }
 
         // Process outbounds
-        var customOutboundsNode = fullConfigTemplateNode["outbounds"] is JsonArray outbounds ? outbounds : [];
+        var customOutboundsNode = fullConfigTemplateNode["outbounds"] is JsonArray outbounds ? outbounds : new JsonArray();
         foreach (var outbound in _coreConfig.outbounds)
         {
             if (outbound.type.ToLower() is "direct" or "block")
@@ -44,7 +44,7 @@ public partial class CoreConfigSingboxService
         // Process endpoints
         if (_coreConfig.endpoints != null && _coreConfig.endpoints.Count > 0)
         {
-            var customEndpointsNode = fullConfigTemplateNode["endpoints"] is JsonArray endpoints ? endpoints : [];
+            var customEndpointsNode = fullConfigTemplateNode["endpoints"] is JsonArray endpoints ? endpoints : new JsonArray();
             foreach (var endpoint in _coreConfig.endpoints)
             {
                 if (endpoint.detour.IsNullOrEmpty() && !fullConfigTemplate.ProxyDetour.IsNullOrEmpty())

v2rayN/ServiceLib/Services/CoreConfig/Singbox/SingboxDnsService.cs

@@ -433,17 +433,15 @@ public partial class CoreConfigSingboxService
     {
         GenDnsProtectCustom();
 
-        _coreConfig.dns?.servers?.RemoveAll(s => s.tag == Global.SingboxLocalDNSTag);
+        var localDnsServer = _coreConfig.dns?.servers?.FirstOrDefault(s => s.tag == Global.SingboxLocalDNSTag);
-        var dnsItem = context.RawDnsItem;
+        if (localDnsServer == null)
-        var localDnsServer = new Server4Sbox()
         {
-            address = string.IsNullOrEmpty(dnsItem?.DomainDNSAddress)
+            return;
-                ? Global.DomainPureIPDNSAddress.FirstOrDefault()
+        }
-                : dnsItem?.DomainDNSAddress,
+        localDnsServer.type = null;
-            tag = Global.SingboxLocalDNSTag,
+        localDnsServer.server = null;
-            detour = Global.DirectTag,
+        var dnsItem = context.RawDnsItem;
-        };
+        localDnsServer.address = string.IsNullOrEmpty(dnsItem?.DomainDNSAddress) ? Global.DomainPureIPDNSAddress.FirstOrDefault() : dnsItem?.DomainDNSAddress;
-        _coreConfig.dns?.servers?.Add(localDnsServer);
     }
 
     private Rule4Sbox BuildProtectDomainRule()

v2rayN/ServiceLib/Services/CoreConfig/V2ray/V2rayConfigTemplateService.cs

@@ -19,12 +19,9 @@ public partial class CoreConfigV2rayService
         // Handle balancer and rules modifications (for multiple load scenarios)
         if (_coreConfig.routing?.balancers?.Count > 0)
         {
-            var balancer =
+            var balancer = _coreConfig.routing.balancers.First();
-                _coreConfig.routing.balancers.FirstOrDefault(b => b.tag == Global.ProxyTag + Global.BalancerTagSuffix, null);
 
             // Modify existing rules in custom config
-            if (balancer != null)
-            {
             var rulesNode = fullConfigTemplateNode["routing"]?["rules"];
             if (rulesNode != null)
             {
@@ -37,7 +34,6 @@ public partial class CoreConfigV2rayService
                     }
                 }
             }
-            }
 
             // Ensure routing node exists
             if (fullConfigTemplateNode["routing"] == null)
@@ -101,8 +97,8 @@ public partial class CoreConfigV2rayService
                     continue;
                 }
             }
-            else if (!fullConfigTemplate.ProxyDetour.IsNullOrEmpty()
+            else if ((!fullConfigTemplate.ProxyDetour.IsNullOrEmpty())
-                && (outbound.streamSettings?.sockopt?.dialerProxy.IsNullOrEmpty() ?? true))
+                && ((outbound.streamSettings?.sockopt?.dialerProxy.IsNullOrEmpty() ?? true) == true))
             {
                 var outboundAddress = outbound.settings?.servers?.FirstOrDefault()?.address
                     ?? outbound.settings?.vnext?.FirstOrDefault()?.address

v2rayN/ServiceLib/Services/CoreConfig/V2ray/V2rayRoutingService.cs

@@ -39,9 +39,9 @@ public partial class CoreConfigV2rayService
                     .ToList() ?? [];
                 if (balancerTagList.Count > 0)
                 {
-                    foreach (var rulesItem in _coreConfig.routing.rules.Where(r => balancerTagList.Contains(r.outboundTag + Global.BalancerTagSuffix)))
+                    foreach (var rulesItem in _coreConfig.routing.rules.Where(r => balancerTagList.Contains(r.outboundTag)))
                     {
-                        rulesItem.balancerTag = rulesItem.outboundTag + Global.BalancerTagSuffix;
+                        rulesItem.balancerTag = rulesItem.outboundTag;
                         rulesItem.outboundTag = null;
                     }
                 }

v2rayN/ServiceLib/ViewModels/AddServerViewModel.cs

@@ -247,6 +247,11 @@ public class AddServerViewModel : MyReactiveObject
         {
             serverName = SelectedSource.Address;
         }
+        if (!Utils.IsDomain(serverName))
+        {
+            UpdateCertTip(ResUI.ServerNameMustBeValidDomain);
+            return;
+        }
         if (SelectedSource.Port > 0)
         {
             domain += $":{SelectedSource.Port}";
@@ -272,6 +277,11 @@ public class AddServerViewModel : MyReactiveObject
         {
             serverName = SelectedSource.Address;
         }
+        if (!Utils.IsDomain(serverName))
+        {
+            UpdateCertTip(ResUI.ServerNameMustBeValidDomain);
+            return;
+        }
         if (SelectedSource.Port > 0)
         {
             domain += $":{SelectedSource.Port}";