Alex-Devera/3x-ui
1
0
Fork 0
mirror of https://github.com/MHSanaei/3x-ui.git synced 2026-06-05 20:54:14 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

fix(node): suppress unavoidable InsecureSkipVerify alert for cert pinning

Browse source 
FetchCertFingerprint must accept any certificate by design: it fetches a
not-yet-pinned node's leaf cert (trust-on-first-use) so the admin can pin
it. Disabling verification is inherent to that, so go/disabled-certificate-check
cannot be cleared by code changes. Suppress the finding inline, matching the
existing lgtm convention in custom_geo.go.
This commit is contained in:
MHSanaei 2026-06-02 03:58:52 +02:00
parent 327228d8f3
commit f0e459e51e
No known key found for this signature in database
GPG key ID: 7E4060F2FBE5AB7A
1 changed files with 5 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
web/service/node.go
View file

@ -136,20 +136,10 @@ func (s *NodeService) FetchCertFingerprint(ctx context.Context, n *model.Node) (
if err != nil { if err != nil {
return "", err return "", err
} }
var fingerprint string
client := &http.Client{ client := &http.Client{
Transport: &http.Transport{ Transport: &http.Transport{
DialContext: netsafe.SSRFGuardedDialContext, DialContext: netsafe.SSRFGuardedDialContext,
TLSClientConfig: &tls.Config{ TLSClientConfig: &tls.Config{InsecureSkipVerify: true}, // lgtm[go/disabled-certificate-check]
InsecureSkipVerify: true,
VerifyConnection: func(cs tls.ConnectionState) error {
if len(cs.PeerCertificates) > 0 {
sum := sha256.Sum256(cs.PeerCertificates[0].Raw)
fingerprint = base64.StdEncoding.EncodeToString(sum[:])
}
return nil
},
},
}, },
} }
resp, err := client.Do(req) resp, err := client.Do(req)
@ -157,10 +147,11 @@ func (s *NodeService) FetchCertFingerprint(ctx context.Context, n *model.Node) (
return "", err return "", err
} }
defer resp.Body.Close() defer resp.Body.Close()
if fingerprint == "" { if resp.TLS == nil || len(resp.TLS.PeerCertificates) == 0 {
return "", common.NewError("node did not present a TLS certificate") return "", common.NewError("node did not present a TLS certificate")
} }
return fingerprint, nil sum := sha256.Sum256(resp.TLS.PeerCertificates[0].Raw)
return base64.StdEncoding.EncodeToString(sum[:]), nil
} }
func (s *NodeService) GetAll() ([]*model.Node, error) { func (s *NodeService) GetAll() ([]*model.Node, error) {