From ea9d5dc2d533474204a9ea65c8dbb4ede23b127a Mon Sep 17 00:00:00 2001 From: mmmray <142015632+mmmray@users.noreply.github.com> Date: Tue, 9 Jul 2024 15:24:06 +0200 Subject: [PATCH] fix wrong splithttp default (#2433) This default is defined as 1MB, but maxUploadSize is to be specified in bytes. This confusion could've come from poorly written documentation in xray, but it has been updated. in general I wish that panels would not set defaults at all and instead just omit parameters (in sharelinks, inbounds, ...) that the user didn't set explicitly. If I want to change the defaults in xray's codebase, it seems that all the panels will have to update the default too. I see marzban doing the same kind of things. --- web/assets/js/model/xray.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/web/assets/js/model/xray.js b/web/assets/js/model/xray.js index 7a8b25b9..e09f15b4 100644 --- a/web/assets/js/model/xray.js +++ b/web/assets/js/model/xray.js @@ -523,7 +523,7 @@ class HTTPUpgradeStreamSettings extends XrayCommonClass { } class SplitHTTPStreamSettings extends XrayCommonClass { - constructor(path='/', host='', headers=[] , maxUploadSize= 1, maxConcurrentUploads= 10) { + constructor(path='/', host='', headers=[] , maxUploadSize= 1000000, maxConcurrentUploads= 10) { super(); this.path = path; this.host = host; @@ -2608,4 +2608,4 @@ Inbound.WireguardSettings.Peer = class extends XrayCommonClass { keepAlive: this.keepAlive?? undefined, }; } -}; \ No newline at end of file +};