From cc3e6d45bab99fbf79f11de8f9c7d6298f72aa08 Mon Sep 17 00:00:00 2001 From: Zhenyu Qi Date: Thu, 25 Dec 2025 19:23:52 -0700 Subject: [PATCH] fix: handle GitHub API error responses in GetXrayVersions GitHub API returns JSON object instead of array when encountering errors (e.g., rate limit exceeded). This causes JSON unmarshal error: 'cannot unmarshal object into Go value of type []service.Release' Add HTTP status code check to handle error responses gracefully and return user-friendly error messages instead of JSON parsing errors. Fixes issue where getXrayVersion fails with unmarshal error when GitHub API rate limit is exceeded. --- web/service/server.go | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/web/service/server.go b/web/service/server.go index d48a96c3..970c5c0f 100644 --- a/web/service/server.go +++ b/web/service/server.go @@ -529,6 +529,18 @@ func (s *ServerService) GetXrayVersions() ([]string, error) { } defer resp.Body.Close() + // Check HTTP status code - GitHub API returns object instead of array on error + if resp.StatusCode != http.StatusOK { + bodyBytes, _ := io.ReadAll(resp.Body) + var errorResponse struct { + Message string `json:"message"` + } + if json.Unmarshal(bodyBytes, &errorResponse) == nil && errorResponse.Message != "" { + return nil, fmt.Errorf("GitHub API error: %s", errorResponse.Message) + } + return nil, fmt.Errorf("GitHub API returned status %d: %s", resp.StatusCode, resp.Status) + } + buffer := bytes.NewBuffer(make([]byte, bufferSize)) buffer.Reset() if _, err := buffer.ReadFrom(resp.Body); err != nil {