Alex-Devera/3x-ui
1
0
Fork 0
mirror of https://github.com/MHSanaei/3x-ui.git synced 2026-06-05 12:44:22 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

fix(frontend): serialize bulk client delete + drop deprecated Alert.message

Browse source 
useClients.removeMany was firing all DELETEs in parallel via Promise.all.
The 3x-ui backend mutates a single config JSON per request (read /
modify / write), so 20 concurrent deletes raced on the same file: every
request reported success, but only the last writer's copy stuck — about
half the selected clients reappeared after the toast. Replace the
parallel fan-out with a sequential for-of loop so each delete sees the
committed state of the previous one. The trade-off is total latency
(20 * ~250ms = ~5s) which is the correct behavior until the backend
grows a proper /bulkDel endpoint.

Also rename the Alert `message` prop to `title` in
ClientBulkAdjustModal to clear the AntD v6 deprecation warning.
This commit is contained in:
MHSanaei 2026-05-26 23:53:54 +02:00
parent a6a3ef8e64
commit 989333b0b1
No known key found for this signature in database
GPG key ID: 7E4060F2FBE5AB7A
2 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
frontend/src/hooks/useClients.ts
View file

@ -212,10 +212,12 @@ export function useClients() {
const removeManyMut = useMutation({ const removeManyMut = useMutation({
mutationFn: async ({ emails, keepTraffic }: { emails: string[]; keepTraffic?: boolean }) => { mutationFn: async ({ emails, keepTraffic }: { emails: string[]; keepTraffic?: boolean }) => {
const suffix = keepTraffic ? '?keepTraffic=1' : ''; const suffix = keepTraffic ? '?keepTraffic=1' : '';
const results = await Promise.all(emails.map((email) => { const results: Msg<unknown>[] = [];
for (const email of emails) {
const url = `/panel/api/clients/del/${encodeURIComponent(email)}${suffix}`; const url = `/panel/api/clients/del/${encodeURIComponent(email)}${suffix}`;
return HttpUtil.post(url, undefined, { silent: true }); const res = await HttpUtil.post(url, undefined, { silent: true });
})); results.push(res);
}
return results; return results;
}, },
onSuccess: () => invalidateAll(), onSuccess: () => invalidateAll(),

2
frontend/src/pages/clients/ClientBulkAdjustModal.tsx
View file

@ -75,7 +75,7 @@ export default function ClientBulkAdjustModal({ open, count, onOpenChange, onSub
type="info" type="info"
showIcon showIcon
style={{ marginBottom: 16 }} style={{ marginBottom: 16 }}
message={t('pages.clients.bulkAdjustHint')} title={t('pages.clients.bulkAdjustHint')}
/> />
<Form layout="vertical"> <Form layout="vertical">
<Form.Item label={t('pages.clients.addDays')}> <Form.Item label={t('pages.clients.addDays')}>