Alex-Devera/3x-ui
1
0
Fork 0
mirror of https://github.com/MHSanaei/3x-ui.git synced 2026-06-08 14:14:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

fix: update rate limit tests to use CF-Connecting-IP header

Browse source 
The middleware was changed to trust CF-Connecting-IP instead of
X-Real-IP/X-Forwarded-For, but the tests still used the old headers.
TestRateLimitMiddleware_DifferentIPsIndependent was failing because
all requests fell back to the same httptest RemoteAddr.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
root 2026-04-25 15:14:02 +08:00
parent b53703f1a1
commit 67c4f6a1ad
1 changed files with 11 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
web/middleware/middleware_test.go
View file

@ -238,7 +238,7 @@ func TestRateLimitMiddleware_ExceedsLimit(t *testing.T) {
} }
} }
func TestRateLimitMiddleware_XRealIP(t *testing.T) { func TestRateLimitMiddleware_CFConnectingIP(t *testing.T) {
r := gin.New() r := gin.New()
r.Use(RateLimitMiddleware(2, time.Minute)) r.Use(RateLimitMiddleware(2, time.Minute))
r.GET("/test", func(c *gin.Context) { r.GET("/test", func(c *gin.Context) {
@ -248,21 +248,21 @@ func TestRateLimitMiddleware_XRealIP(t *testing.T) {
for range 2 { for range 2 {
w := httptest.NewRecorder() w := httptest.NewRecorder()
req, _ := http.NewRequest("GET", "/test", nil) req, _ := http.NewRequest("GET", "/test", nil)
req.Header.Set("X-Real-IP", "10.0.0.1") req.Header.Set("CF-Connecting-IP", "10.0.0.1")
r.ServeHTTP(w, req) r.ServeHTTP(w, req)
} }
w := httptest.NewRecorder() w := httptest.NewRecorder()
req, _ := http.NewRequest("GET", "/test", nil) req, _ := http.NewRequest("GET", "/test", nil)
req.Header.Set("X-Real-IP", "10.0.0.1") req.Header.Set("CF-Connecting-IP", "10.0.0.1")
r.ServeHTTP(w, req) r.ServeHTTP(w, req)
if w.Code != http.StatusTooManyRequests { if w.Code != http.StatusTooManyRequests {
t.Errorf("expected 429 with X-Real-IP, got %d", w.Code) t.Errorf("expected 429 with CF-Connecting-IP, got %d", w.Code)
} }
} }
func TestRateLimitMiddleware_XForwardedFor(t *testing.T) { func TestRateLimitMiddleware_RemoteAddr(t *testing.T) {
r := gin.New() r := gin.New()
r.Use(RateLimitMiddleware(2, time.Minute)) r.Use(RateLimitMiddleware(2, time.Minute))
r.GET("/test", func(c *gin.Context) { r.GET("/test", func(c *gin.Context) {
@ -272,17 +272,17 @@ func TestRateLimitMiddleware_XForwardedFor(t *testing.T) {
for range 2 { for range 2 {
w := httptest.NewRecorder() w := httptest.NewRecorder()
req, _ := http.NewRequest("GET", "/test", nil) req, _ := http.NewRequest("GET", "/test", nil)
req.Header.Set("X-Forwarded-For", "10.0.0.2, 10.0.0.3") req.RemoteAddr = "10.0.0.2:12345"
r.ServeHTTP(w, req) r.ServeHTTP(w, req)
} }
w := httptest.NewRecorder() w := httptest.NewRecorder()
req, _ := http.NewRequest("GET", "/test", nil) req, _ := http.NewRequest("GET", "/test", nil)
req.Header.Set("X-Forwarded-For", "10.0.0.2, 10.0.0.3") req.RemoteAddr = "10.0.0.2:12345"
r.ServeHTTP(w, req) r.ServeHTTP(w, req)
if w.Code != http.StatusTooManyRequests { if w.Code != http.StatusTooManyRequests {
t.Errorf("expected 429 with X-Forwarded-For, got %d", w.Code) t.Errorf("expected 429 with RemoteAddr, got %d", w.Code)
} }
} }
@ -296,12 +296,12 @@ func TestRateLimitMiddleware_DifferentIPsIndependent(t *testing.T) {
// Exhaust limit for IP 1 // Exhaust limit for IP 1
w := httptest.NewRecorder() w := httptest.NewRecorder()
req, _ := http.NewRequest("GET", "/test", nil) req, _ := http.NewRequest("GET", "/test", nil)
req.Header.Set("X-Real-IP", "10.0.0.10") req.Header.Set("CF-Connecting-IP", "10.0.0.10")
r.ServeHTTP(w, req) r.ServeHTTP(w, req)
w = httptest.NewRecorder() w = httptest.NewRecorder()
req, _ = http.NewRequest("GET", "/test", nil) req, _ = http.NewRequest("GET", "/test", nil)
req.Header.Set("X-Real-IP", "10.0.0.10") req.Header.Set("CF-Connecting-IP", "10.0.0.10")
r.ServeHTTP(w, req) r.ServeHTTP(w, req)
if w.Code != http.StatusTooManyRequests { if w.Code != http.StatusTooManyRequests {
@ -311,7 +311,7 @@ func TestRateLimitMiddleware_DifferentIPsIndependent(t *testing.T) {
// IP 2 should still be allowed // IP 2 should still be allowed
w = httptest.NewRecorder() w = httptest.NewRecorder()
req, _ = http.NewRequest("GET", "/test", nil) req, _ = http.NewRequest("GET", "/test", nil)
req.Header.Set("X-Real-IP", "10.0.0.20") req.Header.Set("CF-Connecting-IP", "10.0.0.20")
r.ServeHTTP(w, req) r.ServeHTTP(w, req)
if w.Code != http.StatusOK { if w.Code != http.StatusOK {