diff --git a/config/version b/config/version index 3d8125c2..dd63a007 100644 --- a/config/version +++ b/config/version @@ -1 +1 @@ -v1.6.6.2 +v1.6.6.3 diff --git a/docs/Tasktracking/2026-04-25-unify-nodes-table-style.md b/docs/Tasktracking/2026-04-25-unify-nodes-table-style.md new file mode 100644 index 00000000..7a360032 --- /dev/null +++ b/docs/Tasktracking/2026-04-25-unify-nodes-table-style.md @@ -0,0 +1,30 @@ +# 2026-04-25 Unify master/worker connected nodes table to a-table + +## Problem + +Worker node used a plain HTML `` to display the connected master node, while master +used ``. This caused several inconsistencies: +- Worker table had no role column, no ellipsis on error column +- Worker empty state had dead-code ternary (checking `nodeRole === 'master'` inside a `v-if="nodeRole === 'worker'"` block) +- Two separate `` instances with overlapping conditions +- 8 lines of CSS (`.node-info-table`, `.node-info-wrap`) only used by the worker table + +## Fix + +Unified both views to a single `` using the existing `nodeColumns` definition: +- Removed `v-if="nodeRole === 'master'"` so the table renders for both roles +- Worker now shows all 7 columns (including role) with proper ellipsis on error +- Empty state handled via `` with role-aware message +- Removed unused `.node-info-table` / `.node-info-wrap` CSS +- Removed the duplicate `` and the dead-code ternary + +## Safety + +The previous v1.6.6.x fixes are not regressed: +- `a-descriptions` tree-shaking issue: not applicable, `` is already in the bundle (used by master) +- `v-else` on table: removed entirely, no conditional rendering on table element +- Self-closing ``: removed worker's ``, empty state is now via table locale prop + +## Files Changed + +- `web/html/nodes.html`: unified to single ``, removed plain table + CSS + duplicate empty state diff --git a/web/html/nodes.html b/web/html/nodes.html index af84480b..1fe2dfef 100644 --- a/web/html/nodes.html +++ b/web/html/nodes.html @@ -1,14 +1,4 @@ {{ template "page/head_start" .}} - {{ template "page/head_end" .}} {{ template "page/body_start" .}} @@ -37,13 +27,13 @@ + size="middle" + :locale="{ emptyText: nodeRole === 'master' ? '{{ i18n "pages.nodes.noWorkerNodes" }}' : '{{ i18n "pages.nodes.noMasterNode" }}' }"> @@ -57,42 +47,6 @@ [[ record.lastSyncAt ? formatTime(record.lastSyncAt) : '-' ]] -
- -
-
- - - - - - - - - - - - - - - - - - - - - - - - - - -
{{ i18n "pages.nodes.nodeId" }}[[ nodes[0].nodeId ]]
{{ i18n "pages.nodes.status" }} - -
{{ i18n "pages.nodes.lastHeartbeat" }}[[ nodes[0].lastHeartbeatAt ? formatTime(nodes[0].lastHeartbeatAt) : '-' ]]
{{ i18n "pages.nodes.lastSync" }}[[ nodes[0].lastSyncAt ? formatTime(nodes[0].lastSyncAt) : '-' ]]
{{ i18n "pages.nodes.syncVersion" }}[[ nodes[0].lastSeenVersion ]]
{{ i18n "pages.nodes.error" }}[[ nodes[0].lastError || '-' ]]
- - -