From 2be473aea36b55fd058d121b795d58b7e7aa49ca Mon Sep 17 00:00:00 2001
From: MHSanaei <ho3ein.sanaei@gmail.com>
Date: Sat, 30 May 2026 17:29:56 +0200
Subject: [PATCH] refactor(frontend): split outbound-only protocol forms into
 per-protocol files

Replace the grouped outbound-only-fields.tsx + outbound-freedom-fields.tsx with one file per protocol under outbounds/protocols/: freedom.tsx, blackhole.tsx, dns.tsx, loopback.tsx (+ barrel). Matches the prompt's 1-file-per-protocol structure. Outbound snapshots unchanged -> no behavior change. typecheck/lint/build green.
---
 .../xray/outbounds/OutboundFormModal.tsx      |  9 +-
 .../xray/outbounds/outbound-only-fields.tsx   | 92 -------------------
 .../xray/outbounds/protocols/blackhole.tsx    | 17 ++++
 .../pages/xray/outbounds/protocols/dns.tsx    | 70 ++++++++++++++
 .../freedom.tsx}                              |  2 +-
 .../pages/xray/outbounds/protocols/index.ts   |  4 +
 .../xray/outbounds/protocols/loopback.tsx     | 11 +++
 7 files changed, 108 insertions(+), 97 deletions(-)
 delete mode 100644 frontend/src/pages/xray/outbounds/outbound-only-fields.tsx
 create mode 100644 frontend/src/pages/xray/outbounds/protocols/blackhole.tsx
 create mode 100644 frontend/src/pages/xray/outbounds/protocols/dns.tsx
 rename frontend/src/pages/xray/outbounds/{outbound-freedom-fields.tsx => protocols/freedom.tsx} (99%)
 create mode 100644 frontend/src/pages/xray/outbounds/protocols/index.ts
 create mode 100644 frontend/src/pages/xray/outbounds/protocols/loopback.tsx

diff --git a/frontend/src/pages/xray/outbounds/OutboundFormModal.tsx b/frontend/src/pages/xray/outbounds/OutboundFormModal.tsx
index af65ede0..6435ea48 100644
--- a/frontend/src/pages/xray/outbounds/OutboundFormModal.tsx
+++ b/frontend/src/pages/xray/outbounds/OutboundFormModal.tsx
@@ -62,9 +62,8 @@ import {
   newStreamSlice,
 } from './outbound-form-helpers';
 import { OutboundCoreProtocolFields } from './outbound-core-fields';
-import { OutboundOnlyProtocolFields } from './outbound-only-fields';
-import { FreedomOutboundFields } from './outbound-freedom-fields';
 import { WireguardOutboundFields } from './outbound-wireguard-fields';
+import { BlackholeFields, DnsFields, FreedomFields, LoopbackFields } from './protocols';
 import './OutboundFormModal.css';
 
 // Pattern A rewrite of OutboundFormModal. Built as a sibling `.new.tsx`
@@ -391,9 +390,11 @@ export default function OutboundFormModal({
 
                     <OutboundCoreProtocolFields protocol={protocol} />
 
-                    <OutboundOnlyProtocolFields protocol={protocol} />
+                    {protocol === 'loopback' && <LoopbackFields />}
+                    {protocol === 'blackhole' && <BlackholeFields />}
+                    {protocol === 'dns' && <DnsFields />}
 
-                    {protocol === 'freedom' && <FreedomOutboundFields form={form} />}
+                    {protocol === 'freedom' && <FreedomFields form={form} />}
 
                     {protocol === 'vless' && (
                       <Form.Item shouldUpdate noStyle>
diff --git a/frontend/src/pages/xray/outbounds/outbound-only-fields.tsx b/frontend/src/pages/xray/outbounds/outbound-only-fields.tsx
deleted file mode 100644
index e491a796..00000000
--- a/frontend/src/pages/xray/outbounds/outbound-only-fields.tsx
+++ /dev/null
@@ -1,92 +0,0 @@
-import { useTranslation } from 'react-i18next';
-import { Button, Form, Input, InputNumber, Select } from 'antd';
-import { DeleteOutlined, PlusOutlined } from '@ant-design/icons';
-
-import { DNSRuleActions } from '@/schemas/primitives';
-
-export function OutboundOnlyProtocolFields({ protocol }: { protocol: string }) {
-  const { t } = useTranslation();
-  return (
-    <>
-      {protocol === 'loopback' && (
-        <Form.Item label={t('pages.xray.outboundForm.inboundTag')} name={['settings', 'inboundTag']}>
-          <Input placeholder={t('pages.xray.outboundForm.inboundTagPlaceholder')} />
-        </Form.Item>
-      )}
-
-      {protocol === 'blackhole' && (
-        <Form.Item label={t('pages.xray.outboundForm.responseType')} name={['settings', 'type']}>
-          <Select
-            options={[
-              { value: '', label: '(empty)' },
-              { value: 'none', label: 'none' },
-              { value: 'http', label: 'http' },
-            ]}
-          />
-        </Form.Item>
-      )}
-
-      {protocol === 'dns' && (
-        <>
-          <Form.Item label={t('pages.xray.outboundForm.rewriteNetwork')} name={['settings', 'rewriteNetwork']}>
-            <Select
-              allowClear
-              placeholder={t('pages.xray.outboundForm.unchanged')}
-              options={[
-                { value: 'udp', label: 'udp' },
-                { value: 'tcp', label: 'tcp' },
-              ]}
-            />
-          </Form.Item>
-          <Form.Item label={t('pages.inbounds.form.rewriteAddress')} name={['settings', 'rewriteAddress']}>
-            <Input placeholder={t('pages.xray.outboundForm.unchangedAddress')} />
-          </Form.Item>
-          <Form.Item label={t('pages.inbounds.form.rewritePort')} name={['settings', 'rewritePort']}>
-            <InputNumber min={0} max={65535} style={{ width: '100%' }} />
-          </Form.Item>
-          <Form.Item label={t('pages.xray.tun.userLevel')} name={['settings', 'userLevel']}>
-            <InputNumber min={0} style={{ width: '100%' }} />
-          </Form.Item>
-          <Form.List name={['settings', 'rules']}>
-            {(fields, { add, remove }) => (
-              <>
-                <Form.Item label={t('pages.xray.outboundForm.rules')}>
-                  <Button
-                    size="small"
-                    type="primary"
-                    icon={<PlusOutlined />}
-                    onClick={() => add({ action: 'direct', qtype: '', domain: '' })}
-                  />
-                </Form.Item>
-                {fields.map((field, index) => (
-                  <div key={field.key}>
-                    <Form.Item wrapperCol={{ md: { span: 14, offset: 8 } }}>
-                      <div className="item-heading">
-                        <span>{t('pages.xray.outboundForm.ruleN', { n: index + 1 })}</span>
-                        <DeleteOutlined
-                          className="danger-icon"
-                          onClick={() => remove(field.name)}
-                        />
-                      </div>
-                    </Form.Item>
-                    <Form.Item label={t('pages.xray.outboundForm.action')} name={[field.name, 'action']}>
-                      <Select
-                        options={DNSRuleActions.map((a) => ({ value: a, label: a }))}
-                      />
-                    </Form.Item>
-                    <Form.Item label="QType" name={[field.name, 'qtype']}>
-                      <Input placeholder="1,3,23-24" />
-                    </Form.Item>
-                    <Form.Item label={t('domainName')} name={[field.name, 'domain']}>
-                      <Input placeholder="domain:example.com" />
-                    </Form.Item>
-                  </div>
-                ))}
-              </>
-            )}
-          </Form.List>
-        </>
-      )}
-    </>
-  );
-}
diff --git a/frontend/src/pages/xray/outbounds/protocols/blackhole.tsx b/frontend/src/pages/xray/outbounds/protocols/blackhole.tsx
new file mode 100644
index 00000000..fb919af2
--- /dev/null
+++ b/frontend/src/pages/xray/outbounds/protocols/blackhole.tsx
@@ -0,0 +1,17 @@
+import { useTranslation } from 'react-i18next';
+import { Form, Select } from 'antd';
+
+export default function BlackholeFields() {
+  const { t } = useTranslation();
+  return (
+    <Form.Item label={t('pages.xray.outboundForm.responseType')} name={['settings', 'type']}>
+      <Select
+        options={[
+          { value: '', label: '(empty)' },
+          { value: 'none', label: 'none' },
+          { value: 'http', label: 'http' },
+        ]}
+      />
+    </Form.Item>
+  );
+}
diff --git a/frontend/src/pages/xray/outbounds/protocols/dns.tsx b/frontend/src/pages/xray/outbounds/protocols/dns.tsx
new file mode 100644
index 00000000..85940d15
--- /dev/null
+++ b/frontend/src/pages/xray/outbounds/protocols/dns.tsx
@@ -0,0 +1,70 @@
+import { useTranslation } from 'react-i18next';
+import { Button, Form, Input, InputNumber, Select } from 'antd';
+import { DeleteOutlined, PlusOutlined } from '@ant-design/icons';
+
+import { DNSRuleActions } from '@/schemas/primitives';
+
+export default function DnsFields() {
+  const { t } = useTranslation();
+  return (
+    <>
+      <Form.Item label={t('pages.xray.outboundForm.rewriteNetwork')} name={['settings', 'rewriteNetwork']}>
+        <Select
+          allowClear
+          placeholder={t('pages.xray.outboundForm.unchanged')}
+          options={[
+            { value: 'udp', label: 'udp' },
+            { value: 'tcp', label: 'tcp' },
+          ]}
+        />
+      </Form.Item>
+      <Form.Item label={t('pages.inbounds.form.rewriteAddress')} name={['settings', 'rewriteAddress']}>
+        <Input placeholder={t('pages.xray.outboundForm.unchangedAddress')} />
+      </Form.Item>
+      <Form.Item label={t('pages.inbounds.form.rewritePort')} name={['settings', 'rewritePort']}>
+        <InputNumber min={0} max={65535} style={{ width: '100%' }} />
+      </Form.Item>
+      <Form.Item label={t('pages.xray.tun.userLevel')} name={['settings', 'userLevel']}>
+        <InputNumber min={0} style={{ width: '100%' }} />
+      </Form.Item>
+      <Form.List name={['settings', 'rules']}>
+        {(fields, { add, remove }) => (
+          <>
+            <Form.Item label={t('pages.xray.outboundForm.rules')}>
+              <Button
+                size="small"
+                type="primary"
+                icon={<PlusOutlined />}
+                onClick={() => add({ action: 'direct', qtype: '', domain: '' })}
+              />
+            </Form.Item>
+            {fields.map((field, index) => (
+              <div key={field.key}>
+                <Form.Item wrapperCol={{ md: { span: 14, offset: 8 } }}>
+                  <div className="item-heading">
+                    <span>{t('pages.xray.outboundForm.ruleN', { n: index + 1 })}</span>
+                    <DeleteOutlined
+                      className="danger-icon"
+                      onClick={() => remove(field.name)}
+                    />
+                  </div>
+                </Form.Item>
+                <Form.Item label={t('pages.xray.outboundForm.action')} name={[field.name, 'action']}>
+                  <Select
+                    options={DNSRuleActions.map((a) => ({ value: a, label: a }))}
+                  />
+                </Form.Item>
+                <Form.Item label="QType" name={[field.name, 'qtype']}>
+                  <Input placeholder="1,3,23-24" />
+                </Form.Item>
+                <Form.Item label={t('domainName')} name={[field.name, 'domain']}>
+                  <Input placeholder="domain:example.com" />
+                </Form.Item>
+              </div>
+            ))}
+          </>
+        )}
+      </Form.List>
+    </>
+  );
+}
diff --git a/frontend/src/pages/xray/outbounds/outbound-freedom-fields.tsx b/frontend/src/pages/xray/outbounds/protocols/freedom.tsx
similarity index 99%
rename from frontend/src/pages/xray/outbounds/outbound-freedom-fields.tsx
rename to frontend/src/pages/xray/outbounds/protocols/freedom.tsx
index 4eb8604d..818cbffe 100644
--- a/frontend/src/pages/xray/outbounds/outbound-freedom-fields.tsx
+++ b/frontend/src/pages/xray/outbounds/protocols/freedom.tsx
@@ -5,7 +5,7 @@ import { DeleteOutlined, PlusOutlined } from '@ant-design/icons';
 import { OutboundDomainStrategies } from '@/schemas/primitives';
 import type { OutboundFormValues } from '@/schemas/forms/outbound-form';
 
-export function FreedomOutboundFields({ form }: { form: FormInstance<OutboundFormValues> }) {
+export default function FreedomFields({ form }: { form: FormInstance<OutboundFormValues> }) {
   const { t } = useTranslation();
   return (
     <>
diff --git a/frontend/src/pages/xray/outbounds/protocols/index.ts b/frontend/src/pages/xray/outbounds/protocols/index.ts
new file mode 100644
index 00000000..54b7e4e6
--- /dev/null
+++ b/frontend/src/pages/xray/outbounds/protocols/index.ts
@@ -0,0 +1,4 @@
+export { default as FreedomFields } from './freedom';
+export { default as LoopbackFields } from './loopback';
+export { default as BlackholeFields } from './blackhole';
+export { default as DnsFields } from './dns';
diff --git a/frontend/src/pages/xray/outbounds/protocols/loopback.tsx b/frontend/src/pages/xray/outbounds/protocols/loopback.tsx
new file mode 100644
index 00000000..d75e693c
--- /dev/null
+++ b/frontend/src/pages/xray/outbounds/protocols/loopback.tsx
@@ -0,0 +1,11 @@
+import { useTranslation } from 'react-i18next';
+import { Form, Input } from 'antd';
+
+export default function LoopbackFields() {
+  const { t } = useTranslation();
+  return (
+    <Form.Item label={t('pages.xray.outboundForm.inboundTag')} name={['settings', 'inboundTag']}>
+      <Input placeholder={t('pages.xray.outboundForm.inboundTagPlaceholder')} />
+    </Form.Item>
+  );
+}